@norman , can you write a feedback?

Thanks for your time and efforts, @avokhmin! I'm not currently actively maintaining FriendlyId any more - @parndt is the main maintainer now, but I do have some feedback.

First, the changes to the CI setup look great, but it would probably be better to have those done in a separate PR from this in order to keep things focused. I suspect those changes could be merged right away, whereas the other stuff might need some more time and discussion. Thank you for that! Keeping the CI setup working properly is useful and valuable work.

Regarding the slug limit, this is a feature that used to be in FriendlyId 3.0, but that I removed from FriendlyId 4.0. My idea at the time was that the size limit could be controlled with Active Record validations or column size limits, so it didn't need to be in the library. Version 3.0 had grown to be so large that I wanted to remove as much as possible from the library to keep it easier to maintain and less likely to conflict with other libraries.

The natural lifecycle of plugins like this is to add, add, add and add more and more and more features; everybody has a good reason for wanting to add the thing they want, and it might be legitimately useful and be well written (as your code looks to be here). But if we accept every one that seems justifiable and well written, eventually the library becomes "bloated". Then, somebody else comes along and writes a competing library that's "like FriendlyId but with less bloat", repeat the cycle over and over again. I think we've all seen this. This is what I wanted to avoid in FriendlyId 4.0 and so I rewrote it from the ground up to be simpler and smaller, and less likely to be a library that projects would want to remove because of bloat. It may sound counterintuitive but I've always encouraged people to use FriendlyId for as little as possible, which I think makes it more useful over the long term.

Your feature looks legitimately useful and well coded, so I'll leave it up to @parndt and other folks if they want to include it, but that's the background on why this feature is not currently included in the library.

Thank you @norman

@avokhmin I agree with @norman here, can you introduce 9ff5fa6 as its own PR so that it's easier to reason about this PR?

Let me know if you would like pointers about that and I'll do my best to help.

@avokhmin I agree with @norman here, can you introduce 9ff5fa6 as its own PR so that it's easier to reason about this PR?

@parndt done, see: #824

git rebase master

@parndt, PR updated.

@parndt, PR updated.

@parndt , something wrong here?

No, just a lack of time at the computer 😄 thanks a lot @avokhmin

@parndt , can I create a PR for next release? Or when it can be?

@avokhmin please, create a PR 😄 👍 thanks

@parndt , done, see: #828

@avokhmin

Does setting slug_limit in the configuration work for you?
I'm using Rails 5.0.6 and friendly_id 5.2.3. I can use :slug_limit from the model:

friendly_id :name, use: :slugged, slug_limit: 50

But if I move it into the initializer:

#
# By default, slug has no size limit, but you can change it if you wish.
#
config.slug_limit = 50

I receive this error after running Product.find_each(&:save):

NoMethodError: undefined method `slug_limit=' for #<#<Class:0x007fd3ea4cf4a8>:0x007fd3ea4cf458>

@nuzelac , I use it only in the config/initializers/friendly_id.rb:

FriendlyId.defaults do |config|
  config.use :slugged, :reserved
  config.slug_limit = 255
end

Gemfile.lock

    friendly_id (5.2.2)
    rails (5.1.4)

do you use :slugged ?

Thank you @avokhmin. I added config.use :slugged and now it works from the initializer.